backbone icon indicating copy to clipboard operation
backbone copied to clipboard

Published 20 hours ago • verified publisher icon jashkenas

Function extend does not properly expose static properties from base classes

Open SylvainCorlay opened this issue 5 years ago • 3 comments

If a backbone model is an ES6 class with a statc property, and one use Model.extend to make a subclass (instead of the ES6 extends), the static properties of the base model are not added to the subclass.

SylvainCorlay avatar Jun 30 '19 10:06 SylvainCorlay

This is one of the issues with ES6 classes. See https://github.com/jashkenas/backbone/issues/3560 for discussion.

blikblum avatar Jun 30 '19 11:06 blikblum

@blikblum I have gone through this discussion earlier. I am not sure the specific issue that I am describing is covered in the discussion..

SylvainCorlay avatar Jun 30 '19 14:06 SylvainCorlay

@SylvainCorlay does my PR fix your issue? Static propery inheritance on the constructors?

oliverfoster avatar Mar 05 '20 17:03 oliverfoster