python-mpv icon indicating copy to clipboard operation
python-mpv copied to clipboard

possible typo

Open eregni opened this issue 4 years ago • 1 comments
trafficstars

When I call the wait_until_playing or wait_until_paused method from an MPV instance I get a TypeError. These two methods call self.wait_for_property('core-idle') I believe the attribute core-idle should be core_idle? -> mpv.py line 906 and 917

eregni avatar Jun 27 '21 16:06 eregni

Thank you for the report.

No, the property is called "core-idle" in libmpv. libmpv uses dashes for all property names. When observing a property through the observer API the name is directly passed through to libmpv. The underscore variants of property names are only used for accessing properties through the MPV object's attributes, since python attribute names cannot contain dashes.

Could you please post a stack trace from the error that you get and post your libmpv version? If you have trouble figuring out your libmpv version you can read it from python like this: python3 -c 'import mpv; print(mpv.MPV().mpv_version)'.

neinseg avatar Jul 03 '21 10:07 neinseg