Jakob Schneider

Results 250 comments of Jakob Schneider

Hmm it's kind of awkward to do completions as the new parser fails when writing `new ##java.lang.Runnable` or just `new java.lang.Runnable` so it seems the completion is not even run?...

Ok I think this is blocked... When writing `import java.lang.Comparable` the compiler succeeds with parsing so the `ImportCompleter` is fired. However, when writing `new java.lang.Comparable` it fails parsing after `new`...

> What if you write `new new java.lang.R` then you should be able to select runnable and have everything filled out Doesn't work

> I guess we should remember it is now called `java_new` Good point.

> Are you trying in an expression context? The term that comes after `new` is a `Type` not `Exp`.

I think I'm starting to narrow down how it works. So on the design side of things, do we want it to work like `ImportNewCompleter` where it fetches next package...

Ok, the core sort of works now. It finds the abstract classes and interfaces in the package we typed. However, I have no idea why no vscode suggestions appear...

Ok this is close to done. The only thing I'm not sure how to approach is that `formatType` doesn't prepend `##` to native types. This means that `NewObjectCompleter` has to...

> > Ok this is close to done. The only thing I'm not sure how to approach is that `formatType` doesn't prepend `##` to native types. This means that `NewObjectCompleter`...

![Screenshot from 2024-05-01 11-56-50](https://github.com/flix/flix/assets/60233376/f47a1c65-697f-4a48-914e-0b5d9ceda775) ![Screenshot from 2024-05-01 11-56-55](https://github.com/flix/flix/assets/60233376/a07428e7-8c77-418e-bf1e-e7e86db7c31f) ![Screenshot from 2024-05-01 11-57-09](https://github.com/flix/flix/assets/60233376/a5612076-4dfc-4920-bfef-cba71ee8c8b7) ![Screenshot from 2024-05-01 11-57-34](https://github.com/flix/flix/assets/60233376/a081e502-4957-4da2-8d60-a3cf8611a61b)