Simon Josefsson

> I like `soh` and `shs`, I am just a little scared of `shs` being close to an `ssh` typo. It might be worth having the opinion of several people...

> Iterating on this, what do we explicitly need in such pull request for distro packages ? I am not sure we need to rename every file, every object and...

> I don't think the optimisation here should be fast typing. `shs` or `soh` is almost the same. Yes, there's a difference, but IMO it's way more likely that one...

Great! I would suggest the following: * Modify gpshell/src/gpshell.c to use LGPLv3+-with-OpenSSL-exception * Modify ./helloworldapplet/src/main/java/net/sourceforge/globalplatform/jc/helloworld/HelloWorldApplet.java to use LGPLv3+-with-OpenSSL-exception (or just LGPLv3 since it is Java...) * Add one top-level file...

Re-reading source code, I notice almost all `*.c` `*.h` files needs to be modified from LGPLv3+ to LGPLv3+-with-OpenSSL-exception too. For example see `globalplatform/src/*.c` and `globalplatform/src/globalplatform/*.h`. But gpshell.c and HelloWorldApplet.java seems...

Sorry, I confused this issue by bringing up other aspects. Let's take a step back. gpshell/LICENSE says: ``` /* Copyright (c) 2012, Karsten Ohme * This file is part of...

> Then the c file should also be LGPLv3+ and an OpenSSL exception Looking forward to a commit to fix it :) Since gpshell is an application, and not linked,...

Thank you -- looks good! -- however gpshell/LICENSE still says 'GNU Lesser General Public License'. I guess that should be 'GNU General Public License'?

Thank you! In globalplatform/ the LICENSE says LGPLv3+-with-OpenSSL-exception, but several of the `src/*.{c,h}` files do not have an OpenSSL exception. I think that should be clarified too? Also in cryptoTest.c...

Thanks -- although I believe that since other files in src/*.{c,h} are linked together with OpenSSL the license exception is needed in all of them. Otherwise there is no permission...