Joe Stein
Joe Stein
I think this is two requests: * **Material design**: to maintain design consistency (more or less) with the website, I don't think we're going to do this. * **AMOLED theme**:...
Suspect: https://github.com/rspec/rspec-expectations/commit/3d97c7ec0d3fcb28c7c97def68ba443634674684 `AliasedMatcher` now delegates almost everything – including and _especially_ `.is_a?` – to the underlying matcher. `Differs::ObjectHavingAttributes` therefore no longer applies to the matcher: https://github.com/mcmire/super_diff/blob/fc418c15f04925e00f32298fc85f74c57591fc69/lib/super_diff/rspec.rb#L45https://github.com/mcmire/super_diff/blob/fc418c15f04925e00f32298fc85f74c57591fc69/lib/super_diff/rspec.rb#L45
I think this has been resolved by #225, specifically https://github.com/splitwise/super_diff/pull/225/files#diff-42748c8eb0945ca999ed767e3bc9481068e029207049709f7b8dfd9f75fbf537R143. There's no mention of also overriding `==`. Presumably the latter is needed in cases where matching fails on some attribute...
The problem is basically that for CRuby, `object_address_for` is trying to reimplement `Object#inspect` in Ruby code, without the low-level information available in the C code. Before Ruby 2.7.0, `object_id` was...
Hi @fwolfst , I'm revisiting some open issues right now. As of #261, we're mostly adopting RSpec's automatic color mode. I see that `parallel_tests` [requests colorized output](https://github.com/grosser/parallel_tests/blob/5716756b9165acde183980fa3780d4f1f416e198/lib/parallel_tests/rspec/runner.rb#L76) from RSpec when...
We could treat `nil` and other primitives as un-diffable against the HavingAttributes matcher. I don't particularly like that because `nil` actually does have attributes `{to_s: '', to_i: 0}` and so...
@panozzaj , sorry for the delay. The `NoMethodError` issue you're describing was also described in #199 and should be solved by #202, which was included in v0.11.0. Feel free to...
Indeed, `JSON.parse(ObjectSpace.dump(nil)) == nil`, so we can't index into that, but I believe this was fixed in #146 (v0.9.0)!
We're falling back on the `DefaultObject` differ; this should just be a matter of introducing an inspection tree builder + operation tree builder that handle `Range` objects specifically. See https://github.com/splitwise/super_diff/pull/259...
Game in question is https://lichess.org/FTlapHig/white You'll notice that this was not checkmate; the Lichess servers believe you left the game. Perhaps you lost Internet connection?