connect-redis-crypto icon indicating copy to clipboard operation
connect-redis-crypto copied to clipboard

Fix initial TTL on set

Open ajermaky opened this issue 3 years ago • 4 comments

The initial TTL fetch for the set method was getting the default TTL set in the options. This is because a call to _getTTL was made after encrypting the session object, which meant the checks on the cookie were now invalid.

Moving the call to TTL before the encryption

ajermaky avatar Jul 15 '21 19:07 ajermaky

Hi @jas- ! Can you help review and push this in? Thanks!

ajermaky avatar Jul 15 '21 19:07 ajermaky

@jas- bumping this as I believe this is a much needed change

ajermaky avatar Oct 09 '21 06:10 ajermaky

Author must of went to go get some milk LMFAO

Romvnly-Gaming avatar Dec 23 '21 19:12 Romvnly-Gaming

Hi @jas- we discovered this issue independently and found this open PR. Can you please address the request from @ajermaky . We would appreciate it.

ajones avatar May 20 '22 17:05 ajones