geekr
geekr copied to clipboard
Provide automated tests
Autotesting is the key in open-sourced project, people can not worry about if their pull request will break the app or not. They will already know the answer.
In first time I recommend this simple way: react-testing-library
Well, I can provide some help, but before issue should be split in test types: ui, api, etc. Also, we need determ where test files should be located: near test subject or tests should have their own directrory
Contact me via Telegram if you want to discuss issue. Or an email.
Well, I can provide some help, but before issue should be split in test types: ui, api, etc.
There should be only one test category - the React code. We don't need to test API because it is external and UI is tested on multiple devices, so I always know if the layout is wrong before publishing a version.
Also, we need determ where test files should be located: near test subject or tests should have their own directrory
I prefer having a separate tests/
folder and have the same structure, as files in the main src/
folder.
I want to test some obvious issues, like props to some components (this issue could've been covered by tests https://github.com/jarvis394/habra/issues/121). But, anyways, writing tests is always a tedious job and such small project doesn't even need them because I have Sentry collecting errors. Every day I just check logs and, if I have an error, I fix it.
So, looks like you don't need tests. Fine, I'll find another issue. Pretty impressed by the app and really wanna help and contribute
yup, thanks in advance!