jarun
TODO: support the incoming v2.0 release of flask-admin
i18n
Currently (as of v1.6.1), flask-admin i18n depends on flask-babelex if it's present, falling back to flask-babel otherwise. Meaning, flask-babel is only used when flask-babelex is not installed. For that reason, we're doing the same thing exactly.
However, recently flask-babel repo got a breaking change merged in, removing all dependencies on flask-babelex. They're planning to make a release candidate for the next version soon (appropriately numbered v2.0, since it includes breaking changes).
We should include appropriate changes in the next (patch?) release, migrating to the new flask-admin version once it's available, and removing dependency on flask-babelex accordingly.
bootstrap
The incoming release of flask-admin is going to drop the support for Bootsrap2 & Bootstrap3 themes. We're currently using the Bootstrap3 theme, so migrating bukuserver to Bootstrap4 would be necessary.
(Note: Bootstrap4 is supported by the version of flask-admin we're currently using, so we don't need to wait for the next release of flask-admin to implement this chance)
We should include appropriate changes in the next (patch?) release, migrating to the new flask-admin version once it's available, and removing dependency on flask-babelex accordingly.
If we have enough users requiring a patch, we'll release one. Else it would be a regular release. If there are certain steps that need to be run before the release, please share. Otherwise, you can also make the next release. That would be simpler. Please let me know if you need any permissions.
We still haven't released a version with the fix for #729 (even though the fix was merged in April)
Right, I am still waiting since only one user reported it... so it may not be a widespread issue right now.
Rather than not being widespread, that user noticed it immediately due to running his own tests in a package manager repo, essentially :sweat_smile:
(And I guess most Buku users who visit GitHub are already used to running nightly, seeing as they couldn't install the latest version from PyPI for months if not years by that point :thinking:)
Can you make a release? Please let me know if you need anything.
Release checklist: https://github.com/jarun/buku/wiki/Release-checklist
I'd rather wait for the release of the new flask-admin version (and add support for it); it appears that in addition to i18n changes, they're also removing bootstrap3 theme support, making further changes necessary to support the new flask-admin release.
It appears that the flask-admin release is finally going to be ready soon(-ish 😅), as the last pre-release target goal is apparently being worked on (they have another one listed, but they've confirmed it to be optional).
Meanwhile, I've tried porting the current Bootstrap4 branch for the nightly version of flask-admin, and it seems there's not a lot of adjustments necessary to proceed once the PyPI release finally drops (mostly related to localization support changes and working around the newly introduced page_size restriction).
Great news! Please let me know when it's done. I will hold the release till then.
Well I guess there's the option of making 2 releases: one with all of the already implemented features (can be done now already I guess), and the other after the flask-admin migration. (That would likely mean there won't be much time between those releases, but this way might be more convenient for the users if there turns out to be some issue with the new flask-admin version 🤔)
It's hard to tell for sure how long exactly that last stretch is going to take (since it appears that they have to rely on volunteer help for it), so there's also that 😅
Supposedly the last identified task for their upcoming release is "nearly done" now 😅
…Meanwhile, I've pushed a flask-admin-v2 branch with preliminary migration code (based on their latest pre-release). With any luck, it could be merged about as soon as their release drops (with updated dependency version, that is).
FYI flask-admin v2.-0 got finally released this week: https://github.com/pallets-eco/flask-admin/releases/tag/v2.0.0
