cosmopolitan icon indicating copy to clipboard operation
cosmopolitan copied to clipboard

[Request] Update of redbean's `sqlite3` version in `lsqlite3` module

Open chrisokuda opened this issue 2 years ago • 2 comments

SQLite 3.35.5 is very old, almost 18 months. Requesting it be updated to the most recent version possible (3.39.2 at submission time).

From redbean-2.0.14.com -i:

:> require("lsqlite3").version()
"3.35.5"

chrisokuda avatar Jul 24 '22 11:07 chrisokuda

I started looking into this, but it may be worthwhile to wait until wal2 changes are merged into master to avoid re-doing these changes. Although I'm not sure when to expect that.

pkulchenko avatar Aug 20 '22 02:08 pkulchenko

The wal2 mode has almost 5 years now. The branch is kept up to date with trunk periodically but there is no indication of it being merged into master any time soon (at least I couldn’t find in the docs or the oficial forum).

jxonas avatar Aug 31 '22 02:08 jxonas

@chrisokuda, @jxonas, I got sqlite upgraded to 3.40 in redbean (https://github.com/pkulchenko/cosmopolitan/tree/sqlite-340), but there is still some work to be done to migrate some of the changes that have been applied in cosmopolitan to the original version. I plan to apply them over the next couple of days.

I've tested it on a couple of fairly complex redbean-based application I have and everything working so far, but if you get a chance to run it, let me know if everything looks good for you.

pkulchenko avatar Nov 21 '22 06:11 pkulchenko

@chrisokuda, @jxonas, I've completed the work and submitted a PR (#699). Take a look.

pkulchenko avatar Nov 24 '22 05:11 pkulchenko

Closing as implemented by #699.

pkulchenko avatar Nov 28 '22 21:11 pkulchenko