Justine Tunney
Justine Tunney
Further note: You say `tensorboard_html_binary(compiler = 1)` to get it to run Closure. https://github.com/tensorflow/tensorboard/blob/master/tensorboard/defs/vulcanize.bzl#L110 Please note there's a lot of hard-coding done in that Java file. It's pretty generalized, but...
Oh and just one more thing: I recommend [avoiding ES6 imports](https://github.com/tensorflow/tensorboard/pull/747). I can't even begin to describe how badly we were burned by them. There doesn't appear to be any...
Please keep in mind, the Closure Compiler is so slow because it was designed to create production release builds for google.com, not for developer iteration. The TensorBoard build system lets...
Yes this is definitely something we need. But the service I work on internally doesn't really have enough code to justify modules. It isn't exactly G+. Which why I haven't...
Internally, we have like all this google web server server infrastructure for serving modules, with a parallel set of build rules, named after legumes, designed specifically to cater to the...
This problem is such a deep rabbit hole that involves more than just builds, but also service architecture. It's something we might not have time to work on at this...
Apologies for the latency on this response. I would love to have Dossier integration. I reached out to the author of Dossier about a month ago in https://github.com/google/closure-library/issues/668. I would...
Thank you for bringing this to our attention. For the record, if you're using Closure Rules at HEAD (which currently isn't recommended) then `suppress = ["reportUnknownTypes"]` will work around this...
Code of conduct? Hahaha. I can't believe people take those things seriously. It's just childish rubbish promoted by people with a political agenda. Keep that nonsense out of engineering.
Oh my gosh thank you for sharing this @mikesamuel! That and [CssDepGraph](https://github.com/mikesamuel/closure-maven-plugin/blob/master/plugin/src/main/java/com/google/closure/plugin/css/CssDepGraph.java) are really going to save me a lot of time. Out of curiosity, is your checkForCycles() function guaranteed...