Jarrod Millman

Results 164 comments of Jarrod Millman

According to https://scipy.github.io/devdocs/reference/generated/scipy.sparse.diags_array.html#scipy.sparse.diags_array diags_array was added in 1.11. But I couldn't find it in the documentation for 1.11. I went searching and it looks like I may have taken it...

What should we do about the dtype issue?

@dschult Thanks!! It looks like your PR only fixes the CI when pyamg is installed (i.e., [linux-cp3.12-optional-deps](https://github.com/jarrodmillman/scikit-image/actions/runs/11359229527/job/31620234520?pr=2#logs)). In the other tests, whne pyamg is not installed, we are getting same...

We should deprecate the old matrix interface now that we've added support for it.

This won't work unless we enable pre-commit.ci for this repo, which we currently haven't done. I would prefer holding off on this for now as it will keep trying to...

I am marking this a draft for now as I want to look into the proposed solutions a bit. (I have the same issue on other repos, so thanks for...

I would go with `_generate_random_paths` for the 2.6 release, and revisit it with NXEP3. The rename could be a separate PR, since it should be merged quickly. It probably makes...

I think we all understand the arguments for making it public or private. So I will leave it to @dschult to decide. It if is made public in 2.6 and...

@dschult Here is another suggestion (but you and Ross should make the call on this): We could mark the function private in `networkx/algorithms/similarity.py`; but then import it in the top-level...