Jarrod Chesney
Jarrod Chesney
The diff looks simple enough to me.
In my implementation (https://github.com/Synerty/json-cfg-rw), i do use json.dumps. However, i've made changes to json-cfg nodes so that they auto create objects and populate them with the default values when they...
1. It doesn't write the file unless the user tells it to 2. The default data that it auto creates has no effect on what is returned to the user....
I've chosen to use the with block for convenience, the user can choose this or they can call "save_config" them selves. Remembering that I use it to update the config...
> In my opinion in this example you've added abstraction without winning much. You're very correct. I'll keep this in mind, and thank you for the clarity.