Some fa icons are not displayed

[Skyflash]

I'm playing with your theme and i've found some icons (example: fa-nintendo-switch) are not displayed in the skill_icon1 and 2 sections

[jarrekk]

@Skyflash now Jalpc is using font awesome v4.7, the icon fa-nintendo-switch is showing at font awesome v5, it's better to upgrade the version. :)

[Skyflash]

Ummh... let me understand. Can i upgrade myself to v5? I've tried modify the version in the package.json without luck. I'm noob, is not it? :D

[jarrekk]

@Skyflash Do you reinstall packages(npm install) after update package.json?

[Skyflash]

I've never update package.json :) Can you explain me like i'm a noob, please? :D

[jarrekk]

@Skyflash THis is Javascript stuff, npm install reads package.json to get all packages with specified version. So if you want to use new icon with new package version, you need to install new version package:

1. Update package.json
2. Run npm install at localhost
3. Run npm build
4. Use jekyll server --watch to see changes

After your update is done, you should compress CSS/JS files then push code to GitHub.

I will update this code in https://github.com/jarrekk/Jalpc, maybe you can get a new code from here. :)

[Skyflash]

Ok. Now, under dependencies, i have: components-font-awesome": "^4.7.0"

I think i'll have to google how i can upgrade to 5, isn't it? :D

Or i can wait your modifications and copy them into my code. I this month i have modified your oroginal code a lot and, i'm sorry, i'll never pulled to you.

I have added the jekyll-seo-tag plugin, modified the html code for the descriptions, excerpts and i modified the footer includes (now the footer is only one and the if logic is into that)

[jarrekk]

@Skyflash glad to hear this, some investigation just now, font-awesome 5.* is not compatible for font-awesome 4.* and font-awesome 5.* has a pro version which needs to pay for it, I need to have more work on this, but you can try on your code.