Jaromil

Results 354 comments of Jaromil

I like it on a first read: less code and more readable, good simplifying strategy. Are all corner cases observed covered by test units? I fhink is worth adding a...

when anyone of us has time to update sharness lets do it in a separate PR. oh and BTW I really appreciate your substantial help on maintenance chores and updates...

I just gave the tests a rerun and is now passing, perhaps some hiccup. I think this is an excellent PR! and has priority over others to be merged. I...

@Narrat I need some help after solving conflicts with master. Maybe there is something I've done wrong? Beware here I force pushed my conflict resolution over your old branch, so...

many thanks! looks good even with the small hack on tombname, still less invasive and feasible for now. I agree we could look into making the `[]` disappear, I don't...

Definitely a place that needs improvement, thanks for the extensive analysis. Will be watching this PR, according to your intentions we should end up with less code and more readable...

I will look into your PR and try to merge above conflicts as I did merge some duplicate code with mine, apologies for the mess. to this analysis let me...

the tests should not fail in general. I see the problem here https://github.com/dyne/tomb/actions/runs/10100450578/job/27931822219?pr=527#step:6:706

Many thanks! I've just solved conflicts with other merged PRs, upcoming release will include this very useful improvement!

The problem with this is that `--kdf` needs an argument. I think the built-in option parsing in zsh (`zparseopts`) does not support the "default or optional values" mechanism. I am...