findroid icon indicating copy to clipboard operation
findroid copied to clipboard

Published 20 hours ago • verified publisher icon jarnedemeulemeester

Move away from strings in conditions

Open lsrom opened this issue 3 years ago • 3 comments

This probably comes from Jellyfin SDK but they are trying to work on it as well. We should not use strings inside conditions and rather declare enums corresponding to SDK types and use those. For example item status (continuing/ended), item type (movie/series) etc.

lsrom avatar Oct 20 '21 11:10 lsrom

Yeah I agree. But I think this should really be fixed in the SDK instead of only in this project

jarnedemeulemeester avatar Oct 20 '21 15:10 jarnedemeulemeester

I disagree. Fix in SDK can take a long time and even if they change it to enum it is generally bad practice to depend on server side enums in you code since single change on their side means fixing your code in multiple places. Having own enum means you only have one place to fix. Great benefits for a little work.

lsrom avatar Oct 20 '21 17:10 lsrom

You make a good point, I didn't think about that. Let's use enums in this project

jarnedemeulemeester avatar Oct 21 '21 07:10 jarnedemeulemeester