jarnedemeulemeester
Added a preferred stream quality option
Added the option to select a preferred stream quality in the player settings. This works for both ExoPlayer and mpv. You can either request the original file, or ask for a specific resolution (4K, 1080p, 720p, 480p, 360p). If the asked resolution is lower than the original file's, it will require transcoding.
Ideally, the option to switch the quality should have been directly inside the player, however, I haven't found an easy way to set different stream URLs for different resolutions.
Please note that this option is only for video streaming, downloads still use the original file regardless.
Changed DropDownPreference to ListPreference to suit the new style, as per @Yash-Garg 's suggestion.
Does it consume less bandwidth or is it just a local resolution selector?
Will there be a setting to set it to different Values when using WIFI or mobile?
Does it consume less bandwidth or is it just a local resolution selector?
Will there be a setting to set it to different Values when using WIFI or mobile?
The transcoding is done server side, so that it consumes less bandwith. Currently, the implementation is very basic, the resolution is selected manually by the user, there's no WiFI/mobile data specific setting.
@e2fo2l I have yet to fully test this but is it normal for the Jellyfin dashboard to say the the file is direct playing while obviously transcoding? (High FFmpeg usage and lower video quality)
I don't know, the transcodeReason is properly set to "ContainerBitrateExceedsLimit" when requesting the HLS stream, perhaps there is another parameter missing so that jellyfin properly logs the transcoding
Why don't they accept PR? I have a pretty weak tablet that can't play 1080p Useful feature
Why don't they accept PR? I have a pretty weak tablet that can't play 1080p Useful feature
I think he's not getting much time, let's wait for a reply. I'll suggest to use the build that is generated or create one from this PR in the meantime.
Hello, I haven't had the time to thoroughly troubleshoot the issue with the web panel not showing the stream as being transcoded. To me, that seems like an issue on Jellyfin's end though, because the video IS being transcoded, and should be reported as such.
@OpenSourceSimon Ideally, I would also like the option to have the resolution selector directly in the player, however, I don't have that much experience working with ExoPlayer. This could maybe be implemented in a separate PR.
Sorry for the long wait everyone. I have indeed been pretty busy lately. I first want to merge #329, this is a big rework of how items are handles in Findroid (and will require some changes to this PR). I would be happy to work on those changes once I have merged the rework.
I am also more a fan of a resolution selector directly in the player UI but that can indeed be implemented in a separate PR. I am also not sure yet how that would be implemented but I'm sure someone will figure it out :smile:
Hello, Sorry for not replying earlier, I haven't had any spare time to work on this. I'll try adapting the code to the new refactor this week, hopefully it shouldn't take too long.
