inspect-process icon indicating copy to clipboard operation
inspect-process copied to clipboard

update lib/devtools to set window size and position on initialization

Open starpit opened this issue 7 years ago • 3 comments

this avoids the flashing in the current impl, as the size is set after the window has already opened

this also adds the ability for callers to specify the window size, whereas before the height was hardwired

starpit avatar Jun 19 '17 00:06 starpit

Coverage Status

Coverage decreased (-2.3%) to 93.22% when pulling fd91564bde8cd7c50a5c38e333c63ffad2167245 on starpit:set_window_size_and_pos_on_init into aad69e58a05ce98ec673dcdc96fabce2170d83bc on jaridmargolin:dev.

coveralls avatar Jun 19 '17 01:06 coveralls

Coverage Status

Coverage decreased (-2.3%) to 93.22% when pulling f090e1e2232191214656f2e07964cda3aabde12e on starpit:set_window_size_and_pos_on_init into aad69e58a05ce98ec673dcdc96fabce2170d83bc on jaridmargolin:dev.

coveralls avatar Jun 19 '17 01:06 coveralls

This is definitely better than the current approach. Would like to take the sizing one step further and support #47

I am going to add the options to the CLI and get this merged. Thank you!

jaridmargolin avatar Jul 19 '17 14:07 jaridmargolin