jargons.dev icon indicating copy to clipboard operation
jargons.dev copied to clipboard

fix(ui): added component for users to contribute missing search terms

Open DevYoma opened this issue 1 year ago • 3 comments

Description

This PR replaces the No Result found with a SearchSuggestionContribution component similar to that of the ContributeCTA astro component

Related Issue

Fixes #68

Screenshots/Screencasts

image

Notes to Reviewer

The SearchSuggestionContribution component is similar to the ContributeCTA component.

DevYoma avatar Sep 12 '24 16:09 DevYoma

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jargons-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 11:31am

vercel[bot] avatar Sep 12 '24 16:09 vercel[bot]

Yeah, your approach is good. We can work on it together. Now the only thing I want to ask is how we're going to use the ContributeCTA component that's in astro in the search.jsx island

DevYoma avatar Sep 13 '24 11:09 DevYoma

how we're going to use the ContributeCTA component that's in astro in the search.jsx island

Oh, that you already done with your introduction of the SearchSuggestionContribution locally in the search island.

Here's what we just have to do next...

  • Edit the SearchSuggestionContribution component content to something we will both agree on
  • Position the SearchSuggestionContribution component in the appropriate place and style to achieve the arrangement
  • Implement a debounce functionality to to achieve the display delay

So, I'll handle the debounce functionality.

I'll let you handle the arrangement; below is a quick video of how I was able to achieve the arrangement within the browser, note the new classes I added etc.. Hopefully this helps

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.09.13-16_24_32.webm

babblebey avatar Sep 13 '24 15:09 babblebey

Hey @DevYoma

This PR will now be close as the functionality is considered "no-longer required" following the introduction of feat: implement search with ✨jAI

This feature introduces a guardrail for cases where results for a word isn't found in the dictionary introducing the ability to search for the word with ✨jAI

We are however looking to implement AI Prompted Word Contribution with ✨jAI - https://github.com/jargonsdev/roadmap/issues/9 which takes the word whose meaning was generated by AI because it wasn't in the dictionary, acts and suggests for such word to be contributed to the dictionary.

babblebey avatar Sep 30 '25 23:09 babblebey