jargons.dev icon indicating copy to clipboard operation
jargons.dev copied to clipboard

Published 20 hours ago • verified publisher icon jargonsdev

feat: Add loading component to recent search

Open amiabl-programr opened this issue 1 year ago • 7 comments

Description

This PR adds a loading component to recent searches

Related Issue

Resolves #31

Screenshots/Screencasts

Screenshot 2024-09-01 145214

amiabl-programr avatar Sep 01 '24 13:09 amiabl-programr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jargons-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 5:24am

vercel[bot] avatar Sep 01 '24 13:09 vercel[bot]

If there's no recent search, it should display "no recent search"?

amiabl-programr avatar Sep 02 '24 16:09 amiabl-programr

image

Here's my thought in Visuals 😉

babblebey avatar Sep 02 '24 16:09 babblebey

image

Here's my thought in Visuals 😉

Ok, I think I understand now

amiabl-programr avatar Sep 02 '24 17:09 amiabl-programr

Hey @amiabl-programr,

How's it going with you?? Need any help here??? 😉

babblebey avatar Sep 14 '24 10:09 babblebey

I'll update the PR this evening

amiabl-programr avatar Sep 17 '24 10:09 amiabl-programr

Hey @amiabl-programr,

Great stuff here, but I believe we can keep this super simple removing the overheads of introducing the new components and consumption of the browser apis 🤔

The LoadingComponent can be declared/created locally within the recent-search island and used in the null block of the component

Alright

amiabl-programr avatar Nov 20 '24 04:11 amiabl-programr