jargons.dev icon indicating copy to clipboard operation
jargons.dev copied to clipboard

Improve Pagination Component

Open babblebey opened this issue 1 year ago • 2 comments

The current pagination component provides basic functionality with links to the previous and next pages, along with a display of the current page number. This issue requests an enhancement to the pagination component to improve its usability and provide additional features.

Features to Add:

  1. Display of all available pages for easier navigation.
  2. Next and previous navigation links as chevron icons for better visual indication.
  3. An input field that allows users to enter a custom page number for quick navigation.

Design Changes:

Current:

image

Desired: https://app.opensauced.pizza/feed

image

Implementation Details:

  1. Update the existing pagination component to include the new features.
  2. Use chevron icons for the next and previous navigation links.
  3. Create a input field for selecting a custom page number.

Acceptance Criteria:

  • The new pagination component should display all available pages, next and previous navigation links as chevron icons, and an input field for custom page selection.
  • The pagination component should be visually appealing and intuitive to use.

Additional Information:

  • This enhancement will improve the user experience by providing more intuitive navigation options and making it easier for users to navigate through the pages.

babblebey avatar Apr 24 '24 15:04 babblebey

I want to work on this

amiabl-programr avatar Aug 29 '24 17:08 amiabl-programr

...and where is that pagination located?

amiabl-programr avatar Aug 29 '24 17:08 amiabl-programr

Hi @babblebey , I’m interested in working on this issue as my first contribution to open source.

sirconfy avatar Oct 03 '25 18:10 sirconfy

Oh great @sirconfy

Let's do it šŸ’ŖšŸ¾

I'm assigning you the issue, kindly reach out here if you need any help either during set-up or as you approach the fix.

babblebey avatar Oct 03 '25 18:10 babblebey

Alright. Thanks @babblebey

sirconfy avatar Oct 03 '25 18:10 sirconfy

@babblebey I am getting this error. Please how do I get the appId?

Image

sirconfy avatar Oct 03 '25 22:10 sirconfy

This suggests to me that you might have skipped the dev/setup step while setting your local environment šŸ¤”

Did you run the npm run setup script as stated in the "Run Project Locally" section of the main README - https://github.com/jargonsdev/jargons.dev?tab=readme-ov-file#run-project-locally?

babblebey avatar Oct 04 '25 01:10 babblebey

@babblebey when I run the npm run steup it doesn't run anything (take a look at the image below).

Image

sirconfy avatar Oct 04 '25 10:10 sirconfy

Please create an issue about this on the repo here.

As you write the issue, this will make it real good.

  • Add context... This can be your Operating System, NodeJS Version
  • Screenshot/Screencast(video)

babblebey avatar Oct 04 '25 11:10 babblebey

Issue raised

sirconfy avatar Oct 04 '25 12:10 sirconfy

@babblebey It is working now. I switched to Windows

sirconfy avatar Oct 08 '25 14:10 sirconfy

It is working now. I switched to Windows

Thanks for letting me know this.... Could you kindly update the issue suggesting that this might be associated to masOS???

babblebey avatar Oct 08 '25 14:10 babblebey

@babblebey I cannot see the mentioned pagination. Please, how do I locate it? The image shows the current look of the app on my browser.

Image

sirconfy avatar Oct 09 '25 11:10 sirconfy

Okay, so pagination are on pages with plenty words!

We use them on the browse word by alphabet page.

Go to the /browse page, clicking on the Browse Words link below the Search form in the homepage. Then explore different alphabets, you'll find the pagination components rendered on any alphabet page with words so much that it paginates.

Let me know how it goes.

babblebey avatar Oct 09 '25 14:10 babblebey

Image @babblebey, which component in the code base can I locate the stuff I marked in the image? The toggling is not allowing me to text what I am implementing. I have checked and couldn't locate the component where it's been rendered. Thanks

sirconfy avatar Oct 10 '25 21:10 sirconfy

Haha šŸ˜†

That's not related to the project, its related to Astro, the lib we built the project with... Here's a guide to disabling it for you https://docs.astro.build/en/guides/dev-toolbar/#per-user

babblebey avatar Oct 10 '25 21:10 babblebey

Thanks, after disabling it when pushing and making a PR do I need to enable it?

sirconfy avatar Oct 10 '25 21:10 sirconfy

Image @babblebey Please confirm the pagination design before I make a PR. Functionality-wise, everything works fine.

sirconfy avatar Oct 10 '25 21:10 sirconfy

Best way to confirm is to just create PR šŸ˜‰... we can go over it then...

One note though... the go to page button... Black please #000000

babblebey avatar Oct 10 '25 22:10 babblebey

@babblebey I just made a PR

sirconfy avatar Oct 11 '25 10:10 sirconfy

Image @babblebey I noticed this formatting failure. What do I do ?

sirconfy avatar Oct 11 '25 13:10 sirconfy

https://github.com/jargonsdev/jargons.dev/pull/237#pullrequestreview-3327256076

babblebey avatar Oct 11 '25 14:10 babblebey

@babblebey Please confirm. I have fixed the issue and made a push. Thanks

sirconfy avatar Oct 13 '25 08:10 sirconfy

@babblebey can you confirm I made a Push since 5 days ago. I have fixed the suggestion made by copilot.

sirconfy avatar Nov 06 '25 21:11 sirconfy