chilipie-kiosk icon indicating copy to clipboard operation
chilipie-kiosk copied to clipboard

Session cleanup issue

Open crisp2u opened this issue 4 years ago • 7 comments

Hello,

After playing a bit with this wonderful tool I noticed that for me the previous session cleanup that is done here

https://github.com/futurice/chilipie-kiosk/blob/818a81335f8ec75e367b60339d1a481613e5db63/home/.xsession#L29

is not working. rm is passed a Last Session file that contains a space and fails.

I tried manually running this with find .config/chromium/ -name "Last *" -exec rm {} + and is looking good.

Anyone else experiencing this ?

I'm running the v2.1.0

crisp2u avatar Sep 17 '19 15:09 crisp2u

Thanks for reporting this! It indeed looks like it might not work as intended.

Possible reason for why no-one's noticed is that it's actually not needed all that often, Chromium recovers fine on its own most of the time.

So this manifested as the "Chrome didn't shut down correctly :(" page after a reboot?

jareware avatar Sep 18 '19 05:09 jareware

No, in my case It was a lot of tabs opened after restarts. I actually realized this when testing the tab cycle feature between two tabs opened from the command line

crisp2u avatar Sep 18 '19 06:09 crisp2u

I added this to my .xsession before chromium-browser --start-fullscreen...

sudo rm -r ~/.cache/chromium sudo rm -r ~/.config/chromium/Default/

Refer to issue 47 to see why I used this for.

matristain avatar Sep 18 '19 14:09 matristain

@crisp2u hmm, Chromium IS configured to reopen any tabs that were open when it shut down (or crashed)... do you mean there were more than that when it reopened?

jareware avatar Sep 19 '19 06:09 jareware

@jareware Yes, I had quite a few tabs opened. I open 3 tabs by passing 3 urls as arguments to chromium-browse in ~/.xsession. I believe that was the intention of the above line in ~/.xsession, to delete the chromium Last Session but that fails, like I explained above

crisp2u avatar Sep 22 '19 12:09 crisp2u

added a PR #80

crisp2u avatar Sep 22 '19 12:09 crisp2u

OK, thanks, I'll check that out ASAP!

jareware avatar Sep 23 '19 09:09 jareware