electron-icon-maker icon indicating copy to clipboard operation
electron-icon-maker copied to clipboard

Add option for electron-builder

Open safu9 opened this issue 6 years ago • 5 comments

electron-builder uses flat dir structure of icons unlike electron-packager. I added the option to flatten output structure. It is disabled by default.

(And, I adjust some indents. If you feel this adjustment unnecessary, no problem to ignore.)

safu9 avatar Nov 24 '18 07:11 safu9

Wanted to bump / put in a vote of confidence for this!

I'm currently flattening my output structure with a few lines of bash in my processing pipeline (https://github.com/lazerwalker/tracery-dot-app/blob/b3f0bf2022faac7560a5accfaee446424d0ae167/package.json#L14) but this is a much nicer solution.

lazerwalker avatar Jan 18 '19 13:01 lazerwalker

@safu9 since this isn't getting any attention, why don't you make a separate package (electron-builder-icon-maker) so that we don't have to install from your git repo. Thanks!

nklayman avatar Feb 19 '19 18:02 nklayman

Makes sense to me, although it is sad to see this project flounder.

I'm happy to put in the gruntwork of forking + pushing to npm + maintaining if @safu9 doesn't want to. Will probably sit down to do that later this week or early next week if it hasn't happened yet or if @safu9 hasn't chimed in one way or another.

lazerwalker avatar Feb 19 '19 20:02 lazerwalker

Thanks. I'll do it propably within this week or next week. I'm thinking its new name is electron-icon-builder, more simply.

safu9 avatar Feb 20 '19 09:02 safu9

I just published electron-icon-builder.

safu9 avatar Feb 25 '19 06:02 safu9