rarcrack icon indicating copy to clipboard operation
rarcrack copied to clipboard

fix not checking for unrar

Open nn9dev opened this issue 5 years ago • 5 comments

i ran this for like 30 mins before i realised that i didn't have unrar installed. hopefully this helps people in the future.

nn9dev avatar Sep 11 '19 01:09 nn9dev

nah travis hates me. i think it's a problem with 7z but i dunno

nn9dev avatar Sep 11 '19 01:09 nn9dev

@nn9dev I believe you are almost there. It looks like 7z passed but now zip files fail?

jaredsburrows avatar Sep 13 '19 17:09 jaredsburrows

if I was able to tell you what the error was here, i'd be all over it. I honestly do NOT know. if travis was more verbose when running commands and such then MAYBE but I have no idea what's up

nn9dev avatar Sep 13 '19 18:09 nn9dev

Have you tried running your code locally? Then running the commands that travis is running locally?

jaredsburrows avatar Sep 13 '19 18:09 jaredsburrows

It works perfectly fine on my end. I noticed in the Travis build that it doesn't either throw a confirm or an error for the 7z bit of code and so I made it return EXEC_FAILURE which maybe I shouldn't have done because if someone is trying to do a rar and doesn't have 7z then it just halts so maybe I'll revise that but if you can see a way to fix it on Travis I could try to fix that if you see it as necessary

nn9dev avatar Sep 13 '19 19:09 nn9dev