Cyanea icon indicating copy to clipboard operation
Cyanea copied to clipboard

Color applied incorrectly

Open xDragonZ opened this issue 5 years ago • 8 comments

While implementing and testing around, I found out that sometimes colors are applied incorrectly and it required clear app data to reset it. Sometimes force stop app will help, sometimes it require clear app data.

Noticed that the color accent applied to TextView/CardView/ActionBar title where it shouldn't.

Tested on: normal device and emulator, android 9.0 and 8.0 with v1.0.1 library

Comparing the "normal" pref xml (com.jaredrummler.cyanea) and "incorrect" xml, found out accent_light and accent_dark values is different.

Not sure is related to pref commit is having race condition or the activity recreated and wrong color applied.

I decided to test on the demo app that downloaded directly from here, which also the same results.

image

image

Video: https://file.io/GEztLq or https://upload.cat/88665821462cd5ed

xDragonZ avatar Dec 11 '18 20:12 xDragonZ

I was able to reproduce. I think this has to do with the accent color being the same as the primary text color. Will do more investigating and fix this when I have time later this week.

jaredrummler avatar Dec 12 '18 05:12 jaredrummler

Is it related to the if-else detecting for the dark color giving the problem?

xDragonZ avatar Dec 17 '18 12:12 xDragonZ

Unfortunately I have been extremely busy with work. Will work on this soon, most likely after CES.

jaredrummler avatar Jan 10 '19 02:01 jaredrummler

I was able to reproduce this issue. As a workaround I removed cyanea_primary_reference from my colors.xml

paprikanotfound avatar Feb 18 '19 15:02 paprikanotfound

@jaredrummler it will be great if you can tag current changes to new version (1.0.2) and release it.

xDragonZ avatar Mar 09 '19 10:03 xDragonZ

Any updates on this?

jrcacd avatar Apr 12 '19 08:04 jrcacd

Having the same issue, the workarround provided by @stavangr doesnt seem to work for me.

ricrebelo avatar Jun 25 '19 10:06 ricrebelo

I meeting the same problem,so i want to know the error solve.But now i see the issue still is open ,the dev still not fix?

XuanRanDev avatar Jan 04 '21 03:01 XuanRanDev