ColorPicker icon indicating copy to clipboard operation
ColorPicker copied to clipboard

Bug: when using the dependency from Jitpack, the translations are gone

Open AndroidDeveloperLB opened this issue 2 years ago • 2 comments

It seems as if what's on Jitpack is older than what's on the repository, or something. Steps:

  1. Run the sample as it is
  2. Change device locale to Hebrew ("עברית")
  3. Run the sample again and check what happens for the "Color picker with alpha". Notice that the texts have changed.
  4. Now change in the gradle file, to this:
//  implementation project(':library')
implementation 'com.jaredrummler:colorpicker:1.1.0'
  1. Try what's on step 3.

The bug is that it is in English.

See here:

https://user-images.githubusercontent.com/5357526/171374468-be4bbb82-c3ce-4311-8307-f2f910261604.mp4

ColorPicker.zip

Workaround: use Jitpack instead, to reach the latest commit:

implementation 'com.github.jaredrummler:ColorPicker:eb76c92f53'

See attached project with all 3 options tested. ColorPicker.zip

Also, BTW, if you don't want the icon of the preferences, this is a better way instead of using the app-compat PreferenceGroupAdapter class: https://stackoverflow.com/a/51568782/878126

AndroidDeveloperLB avatar Jun 01 '22 09:06 AndroidDeveloperLB

I actually prefer that we could set the strings ourselves, to let translators handle it.

AndroidDeveloperLB avatar Jun 01 '22 20:06 AndroidDeveloperLB

Here, created a way to customize them all: https://github.com/AndroidDeveloperLB/ColorPicker https://github.com/jaredrummler/ColorPicker/pull/110

AndroidDeveloperLB avatar Jun 01 '22 21:06 AndroidDeveloperLB