pell icon indicating copy to clipboard operation
pell copied to clipboard

There is no way out of <blockquote>

Open okbel opened this issue 6 years ago • 9 comments

Once you click Quote it starts creating new <blockquote>s tags. I can't exit the quote while I'm typing. Even with double enters, or tab.

okbel avatar Mar 09 '18 19:03 okbel

@okbel thanks very much for the feedback. Big update for pell coming soon with tons of fixes, hopefully I can work in a fix for this as well.

jaredreich avatar Mar 09 '18 21:03 jaredreich

Thanks for the quick reply! (And sorry for the short description I wanted to comeback and write detailed steps of repro hah)

Really excited about the update! Let me know how it goes! We are using Pell for Talk here

okbel avatar Mar 10 '18 19:03 okbel

@okbel No worries. v1.0.1 includes a fix for the blockquote escaping, as well as making sure the first child element in the editor is properly wrapped in a tag (I noticed you have a workaround for this in this file: https://github.com/coralproject/talk/blob/master/plugins/talk-plugin-rich-text-pell/client/utils.js Perhaps you don't need the workaround anymore.

The coral project looks pretty cool, kudos to you and your team.

Maybe I can post a "Who uses pell" section on this README and list that project there. Let me know if you're okay with that.

jaredreich avatar Mar 12 '18 05:03 jaredreich

Thank you! Sure! Feel free to add us to the section.

okbel avatar Mar 12 '18 11:03 okbel

Was this problem relsoved? I'm using ver 1.0.4 but blockquote can't exit

nguyentranchung avatar Oct 08 '18 09:10 nguyentranchung

Click quote button => input something => shift + enter => input something => enter => not escap (bug)

nguyentranchung avatar Oct 08 '18 10:10 nguyentranchung

Interesting, never knew about the shift+enter thing.

jaredreich avatar Oct 08 '18 14:10 jaredreich

I use the outdent execCommand to leave blockquotes, which seems to work well under all circumstances.

litemotiv avatar Jan 27 '19 15:01 litemotiv

I find blockquote very handy, but dont have them. My version is v2 working branch.

RossMWoods avatar Nov 08 '19 03:11 RossMWoods