Jared Parsons
Jared Parsons
Thanks for reporting! @dpoeschl is this a known issue in the rename tracking code?
@dpoeschl I wonder if it's because the latest release is still using a pre-RTM version of Roslyn.
I do think this needs to be off by default but other than that it looks good. Had 1 Q about the trivia tracking. More out of curiosity than a...
@jakesays see the end of the attribute declaration here https://github.com/dotnet/codeformatter/blob/master/src/Microsoft.DotNet.CodeFormatting/Rules/MarkReadonlyFieldsRule.cs#L19 Essentially `DefaultRule = false` is the current method.
:+1: Gave some feedback on a couple of small issues to consider.
@dpoeschl will know how the IDE works here better than me.
Do you mean via a `` or simply an unqualified name in the comment?
I agree that we should do this but the change does have the potential to do incorrect edits in the code. Refactor Rename in the IDE approaches this by making...
I think cross plat is a goal we should definitely shoot for on this tool. The code in the tool itself should be fine for cross plat. It may need...
@mteper large parts of Roslyn are cross platform. The portion that uses MSBuild though is not. At least to my knowledge.