formik icon indicating copy to clipboard operation
formik copied to clipboard

`FieldArray` - make array helpers more type-safe

Open burtek opened this issue 1 year ago • 4 comments

Currently used push<X = T[number]>(obj: X): void; allows to push string to number[]. By changing the signature to push<X extends T[number] = T[number]>(obj: X): void; it won't be possible any more.

burtek avatar Aug 13 '24 12:08 burtek

⚠️ No Changeset found

Latest commit: 8f7a20dce556bb18aae40ece5fc02cd088f686f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 13 '24 12:08 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 0:55am

vercel[bot] avatar Aug 13 '24 12:08 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Aug 13 '24 12:08 codesandbox-ci[bot]

Or, we can get rid of generics here altogether and just do push(obj: [number]): void;

burtek avatar Aug 13 '24 12:08 burtek