formik icon indicating copy to clipboard operation
formik copied to clipboard

[Reopen] Let promise rejection propagate in handleSubmit

Open JoseLion opened this issue 4 years ago • 10 comments

Resolve #2758

Reopening #3052

JoseLion avatar Sep 11 '21 19:09 JoseLion

🦋 Changeset detected

Latest commit: 7a8483cc6397d9a3509f79bc4c528ab0be788f87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 11 '21 19:09 changeset-bot[bot]

@JoseLion is attempting to deploy a commit to the Formium Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 11 '21 19:09 vercel[bot]

This PR (originally) was opened in February, involves a minor but significant fix with no workaround. @johnrom @jaredpalmer could this please be reviewed sometime soon? If you both have too little time for maintaining right now consider getting help from the community?

Thanks for your consideration!

jlsjonas avatar Oct 11 '21 11:10 jlsjonas

I'm a contributor to and not a maintainer of this project. I probably won't be contributing much without commitments to move #3231 forward, as I've already spent enough energy trying to release a v3 here.

johnrom avatar Oct 11 '21 15:10 johnrom

Hi! This issue seems very important to me, as @hixus said, it prevents errors from being captured on Sentry or similar. @jaredpalmer could you check this?

BrOrlandi avatar Mar 30 '22 19:03 BrOrlandi

+1 to previous comments. This part of code doesn't allow to catch errors raised in onSubmit handler using window.onunhandledrejection. @jaredpalmer, please, take a look

avasuro avatar Jul 21 '22 20:07 avasuro

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2023 11:43pm

vercel[bot] avatar Sep 02 '23 12:09 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a8483cc6397d9a3509f79bc4c528ab0be788f87:

Sandbox Source
Formik TypeScript Playground (forked) Configuration
Formik Codesandbox Template (forked) Issue #2758

codesandbox-ci[bot] avatar Sep 02 '23 12:09 codesandbox-ci[bot]

If you're still around, could you add a changeset for this? Or someone can cherry pick into a new PR and add one. Thanks!

quantizor avatar Sep 02 '23 12:09 quantizor

@probablyup I updated the branch and added a chageset following these instructions. Let me know if something's wrong or missing 🙂

JoseLion avatar Sep 10 '23 23:09 JoseLion