formik
formik copied to clipboard
[Reopen] Let promise rejection propagate in handleSubmit
Resolve #2758
Reopening #3052
🦋 Changeset detected
Latest commit: 7a8483cc6397d9a3509f79bc4c528ab0be788f87
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| formik | Patch |
| formik-native | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@JoseLion is attempting to deploy a commit to the Formium Team on Vercel.
A member of the Team first needs to authorize it.
This PR (originally) was opened in February, involves a minor but significant fix with no workaround. @johnrom @jaredpalmer could this please be reviewed sometime soon? If you both have too little time for maintaining right now consider getting help from the community?
Thanks for your consideration!
I'm a contributor to and not a maintainer of this project. I probably won't be contributing much without commitments to move #3231 forward, as I've already spent enough energy trying to release a v3 here.
Hi! This issue seems very important to me, as @hixus said, it prevents errors from being captured on Sentry or similar. @jaredpalmer could you check this?
+1 to previous comments. This part of code doesn't allow to catch errors raised in onSubmit handler using window.onunhandledrejection.
@jaredpalmer, please, take a look
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| formik-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 10, 2023 11:43pm |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 7a8483cc6397d9a3509f79bc4c528ab0be788f87:
| Sandbox | Source |
|---|---|
| Formik TypeScript Playground (forked) | Configuration |
| Formik Codesandbox Template (forked) | Issue #2758 |
If you're still around, could you add a changeset for this? Or someone can cherry pick into a new PR and add one. Thanks!
@probablyup I updated the branch and added a chageset following these instructions. Let me know if something's wrong or missing 🙂