cypress-image-snapshot icon indicating copy to clipboard operation
cypress-image-snapshot copied to clipboard

expand cypress peer dependency versions

Open jdanil opened this issue 3 years ago • 10 comments

Expand cypress peer dependency versions to include v5 and v6.

Fixes #168

jdanil avatar Feb 04 '21 12:02 jdanil

⚠️ No Changeset found

Latest commit: bec2595a5cb2342dc41bc7ba87752e0db502b6b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 04 '21 12:02 changeset-bot[bot]

@jaredpalmer when you get a chance to review 🙏 Wasn't sure if you preferred caret versions (^) or greater than (>=) to avoid this issue for future major version updates.

jdanil avatar Feb 15 '21 03:02 jdanil

@jaredpalmer +1 for this

We might have to update this again very soon because Cypress 7 is going to come out soon and we will be 3 major versions behind, it's a dev dependency so it's not the end of the world, it's just nice to not have to have multiple version of cypress installed.

Develliot avatar Mar 03 '21 13:03 Develliot

Now that cypress v7 is out, I updated this to a >= check to ensure the new version is included, and any future versions.

@jaredpalmer when you get a chance.

jdanil avatar Apr 06 '21 01:04 jdanil

Please merge :) Need this as well

nischi avatar Apr 07 '21 05:04 nischi

Any update on this? I would like this change as well.

Josmithr avatar May 08 '21 00:05 Josmithr

I also would vote for changing this. At the moment I need to run npm i with the --force-flag in my project, which is not a very clean way.

pdaether avatar May 18 '21 15:05 pdaether

Same as @pdaether . This is completely ruining npm install 😭 @jaredpalmer Please please please

ghost avatar Jun 17 '21 15:06 ghost

I would also love to see this merged.

@crosscompile would you be able to help here? @jaredpalmer seems to be unresponsive for a few months.

rabelloo avatar Sep 10 '21 10:09 rabelloo

Any update on this?

ksmills9 avatar Oct 27 '22 21:10 ksmills9