Jared Forsyth comments

Results 199 comments of


                                            Jared Forsyth

Preserve function body braces and distinguish open vs. X.()

This is the main reason I have refmt on save turned off. I might try to get to this to resolve the conflicts if I can in the next couple...

Attempt to remove semicolon

There's a difference between "ASI" that javascript does (which is all kinds of terrible), and "treating a newline as significant" (which swift does). In swift, an opening brace for a...

Attempt to remove semicolon

@ubsan it wouldn't break that code! (see swift, where all of your examples work!) ``` let x = 2 + 3 ``` is perfectly valid swift! (and x resolves to...

[internal] get the reason bspack build script working with esy

@chenglou I changed set to use gnu format. And the "make it work with bsc" is a rather more invasive change, I wanted to get this merged first.

[internal] get the reason bspack build script working with esy

@chenglou latest is 0.2.7 -- could you try that?

[internal] get the reason bspack build script working with esy

@chenglou what do you mean? What errors are you getting?

[internal] get the reason bspack build script working with esy

Ok, fixed it up. Now works with esy `0.2.11`

[internal] get the reason bspack build script working with esy

@jordwalke I did intend to add bspack.ml, and it is generated -- I vendored it here so that you wouldn't have to have the bucklescript source locally

[internal] get the reason bspack build script working with esy

(from my side this is ready to merge)

[internal] get the reason bspack build script working with esy

That means it's finding the wrong version of menhir :/ I'll take a look.