Jared Hirsch

Still seeing the huge tp5o regressions with content scripts totally disabled in 59 (content_scripts section removed from the manifest): https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=febd1a18cbce90f99f95f303c379ba0dff7abb64&newProject=try&newRevision=c5712f41e8a377ed0cbefd5f996ef0eed38e0a56&framework=1&showOnlyImportant=1

OK, starting to narrow down a little. Something either in the StudyUtils.jsm code, or in our use of that code, seems to be causing a lot of the performance problems....

Here's a new run, with StudyUtils removed and where the embedded webextension is never started: on 59: https://treeherder.mozilla.org/#/jobs?repo=try&revision=acd21af2719779fac4ab04a0d50cc1a0f921d597 on 60: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46c310a5fa60b1df3efb171bd68f1e1cd23be608

The last run against 60 produced some inexplicable performance *improvements*, so I'm re-running everything now: - base commit - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fa3fc7d9eaf7ff7db8a70ea6fa012f859d1a47d - minvid, no startup delay - https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc8e7046638ce89425833611c08227c19851c8e5 - minvid with...

> That may be relevant: at the time I was using two displays: one Thunderbolt (non-retina), one MBP (retina). It is reproducible regardless of which display is being used by...

This _may_ be improved now that the player is a window (#475)

Thanks for the ctypes review, @matt-howell! That code has always freaked me out a bit :-P What's the right way to log the error on that line you pointed out?

@Standard8 about the messaging implementation, I struggled getting messaging to work at all, and fell back on polling as a bit of a desperation move. A lot of users have...

Thanks again for the feedback, all. Filing a couple of followup bugs to fix individual issues.

@Standard8 Ah, I remember now: we don't use WebChannel because it [requires the scheme to be https](https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/WebChannel.jsm#179). I think we'd have to wire up some kind of custom MessageManager thing....