passport
passport copied to clipboard
Fix #904, Required regenerate and save API (req.session.regenerate is not a function since upgrade to 0.6.0)
Background RE: #904
Using [email protected]
, [email protected]
with the [email protected]
module to login with Github, the application throws the following error message:
TypeError: req.session.regenerate is not a function at SessionManager.logIn
Feature
Utilize the Delegate Pattern and default to an empty implementation so that the code does not throw an error.
Checklist
- [ x ] I have read the CONTRIBUTING guidelines.
- [ x ] I have added test cases which verify the correct operation of this feature or patch.
- [ x ] I have added documentation pertaining to this feature or patch.
- [ x ] The automated test suite (
$ make test
) executes successfully. - [ x ] The automated code linting (
$ make lint
) executes successfully. (NOTE: Lint errors are with code not touched by this PR)
Is there a possibility of this being merged in the near future? @jaredhanson