passport icon indicating copy to clipboard operation
passport copied to clipboard

Published 20 hours ago • verified publisher icon jaredhanson

Document `failWithError` parameter in authenticate()

Open hsource opened this issue 6 years ago • 5 comments

Helps with #458. I don't know where to submit a change that would update http://www.passportjs.org/docs/authenticate/ but I'd be happy to help with that too

Checklist

  • [x] I have read the CONTRIBUTING guidelines.
  • [x] I have added test cases which verify the correct operation of this feature or patch.
  • [x] I have added documentation pertaining to this feature or patch.
  • [x] The automated test suite ($ make test) executes successfully.
  • [x] The automated code linting ($ make lint) executes successfully.

hsource avatar Jan 03 '19 00:01 hsource

Coverage Status

Coverage remained the same at 98.87% when pulling 19cc7c24969e467e42e2a78572e886993f48df36 on hsource:patch-1 into 882d65e69d5b56c6b88dd0248891af9e0d80244b on jaredhanson:master.

coveralls avatar Jan 03 '19 01:01 coveralls

Coverage Status

Coverage remained the same at 98.87% when pulling 19cc7c24969e467e42e2a78572e886993f48df36 on hsource:patch-1 into 882d65e69d5b56c6b88dd0248891af9e0d80244b on jaredhanson:master.

coveralls avatar Jan 03 '19 01:01 coveralls

What's the status on this?

KerimG avatar Mar 19 '19 14:03 KerimG

This is purely a documentation change so should be submittable.

hsource avatar Mar 19 '19 16:03 hsource

I guess it could be merged!

rap2hpoutre avatar Oct 12 '21 12:10 rap2hpoutre