passport-twitter
passport-twitter copied to clipboard
Allow users to specify both x_auth_access_type and the strategy name …
…in case they need a different set of options for difference use cases. Say normal users vs enterprise users.
** READ THIS FIRST! **
Are you implementing a new feature?
Requests for new features should first be discussed on the developer forum. This allows the community to gather feedback and assess whether or not there is an existing way to achieve the desired functionality.
If it is determined that a new feature needs to be implemented, include a link to the relevant discussion along with the pull request.
Is this a security patch?
Do not open pull requests that might have security implications. Potential security vulnerabilities should be reported privately to [email protected]. Once any vulerabilities have been repaired, the details will be disclosed publicly in a responsible manner. This also allows time for coordinating with affected parties in order to mitigate negative consequences.
If neither of the above two scenarios apply to your situation, you should open a pull request. Delete this paragraph and the text above, and fill in the information requested below.
Checklist
- [ ] I have read the CONTRIBUTING guidelines.
- [ ] I have added test cases which verify the correct operation of this feature or patch.
- [ ] I have added documentation pertaining to this feature or patch.
- [ ] The automated test suite (
$ make test
) executes successfully. - [ ] The automated code linting (
$ make lint
) executes successfully.
Should fix https://github.com/jaredhanson/passport-twitter/issues/63
and
https://github.com/jaredhanson/passport-twitter/issues/87
Coverage remained the same at 100.0% when pulling 8f7d905a1445a67886a0c4cb0124bdb36297c45e on bobber205:master into cfe7807b0e89e9ff130592c28622e134749e757b on jaredhanson:master.