passport-oauth2 icon indicating copy to clipboard operation
passport-oauth2 copied to clipboard

Adding ability to specify a custom agent for OAuth2Strategy via customHeaders

Open kulkame opened this issue 8 years ago • 5 comments

We experienced an issue where we needed to adjust http request agent configurations but could not find anyway of configuring passport oauth2Strategy to propagate those configurations to the underlying library. This PR should resolve that issue in a generic way that is hopefully applicable to future use cases as well.

kulkame avatar May 24 '17 13:05 kulkame

Coverage Status

Coverage remained the same at 100.0% when pulling caa85171946a2fee312af5c49fb19a3b8bc335cc on kulkame:master into a02839afb8d15f7d283ae09167973e4d22e8faf8 on jaredhanson:master.

coveralls avatar May 24 '17 13:05 coveralls

We are facing similar issue.. It would be great if this could be merged soon!

hsalunkhe avatar May 24 '17 15:05 hsalunkhe

@jaredhanson When can we expect this to be merged?

kulkame avatar May 30 '17 07:05 kulkame

+1

msweaver avatar Jun 02 '17 14:06 msweaver

@kulkame if you make a PR against https://github.com/passport-next/passport-oauth2 is will get looked into.

rwky avatar Jul 07 '18 15:07 rwky