passport-oauth2 icon indicating copy to clipboard operation
passport-oauth2 copied to clipboard

Feature Request: Custom State Store

Open ndtreviv opened this issue 6 years ago • 1 comments

I'm using this library (and will happily contribute :) ), and it's doing the job I need really well. BUT: need my app to be stateless as I'm deploying it to Google Cloud Run.

I have minimal state in my app already, which I'm looking to offload to Google Memorystore (effectively Redis). I'd like to write a custom state store for this that, similarly, offloads the state into Redis.

Is this something that you could see as being a valuable addition? If I write in hooks to a custom state store, would you be amenable to reviewing it with a view to merging a PR? I'm only asking before doing because I notice that there are some pretty old PRs on here. I don't want to do the work if it's not going to get pulled.

Thoughts?

ndtreviv avatar Aug 29 '19 19:08 ndtreviv

It appears that you can do this by passing the undocumented store option. See it in use here), and see the examples in the lib/state dir for what should be implemented.

The author's a habit of deliberately not documenting options is sometimes unhelpful.

elyobo avatar Dec 26 '19 10:12 elyobo