Jared Grubb
Jared Grubb
Well, that's not the only one (eg, the `hash` value will change). Maybe we should fix `isLong` to handle both cases?
`isLong` could return true if and only if the call to `asLong` will succeed.
I haven't used GitHub CI before .. how will this appear once merged?
So once we merge this, it'll just kick in? or is there further setup that I'll need to do? Thanks for the idea on this!
I love the idea, and I expect others might too! This would be a major version jump for the library, but maybe that's becoming more appropriate these days?
Is this still an issue?
Unsigned overflow is well-defined as wrap-around. In this code, overflow is expected and is ok. Maybe adding an explicit cast to say "this will overflow and that's ok" would quiet...
I think this would be a good enhancement.
I don't see you doing anything wrong here. Are you still seeing this? What version of compiler are you using?
I'm not a make expert so it'd be nice to get some other eyes on this that can confirm this approach is reasonable.