deploy-hook-forker icon indicating copy to clipboard operation
deploy-hook-forker copied to clipboard

Published 20 hours ago • verified publisher icon jaredatron

option to require secret

Open jjb opened this issue 9 years ago • 2 comments

feature discussed in #6

@deadlyicon @rmm5t Let me know what you think! Any feedback on code or copy is welcome.

jjb avatar Jun 06 '16 01:06 jjb

n.b. i didn't have ruby 2.0.0 available on my machine so i did dev in 2.3.1. Also, for some reason json wasn't building on my machine with the Gemfile.lock as it was, so I did a bundle update before doing dev.

The only possible consequence of this I can think of is that maybe the json in the Gemfile.lock doesn't support pretty_generate

In any case I think we can safely bump up the ruby version, or maybe even don't specify it at all? Heroku doesn't even support ruby 1.9 any more I believe.

jjb avatar Jun 06 '16 01:06 jjb

Does this fit your bill https://github.com/deadlyicon/deploy-hook-forker/pull/11 ?

jaredatron avatar Jun 06 '16 17:06 jaredatron