glava icon indicating copy to clipboard operation
glava copied to clipboard

Improve meson setup

Open QuLogic opened this issue 2 years ago • 0 comments

A variety of things to update and modernize the Meson setup. It would also be good to set a minimum Meson version in your project call, as there are other things that could be done, but I wasn't sure if it would be too new.

  • Rename Meson option names to be more conventional. It is recommended to not use (enable|disable) prefix on option names, as this is not autoconf.
  • Packages that provide a pkg-config file or are supported by Meson should use dependency, not find_library.
  • Both dl and m are glibc-specific, and should be optional in order to build on other systems.
  • Set cpp_std as a build option, use include_directories, and enable hidden symbol visibility again.

I would also say you should explicitly list out the files instead of using find, but you do that so much I didn't want to do that out of the blue.

QuLogic avatar Aug 06 '21 08:08 QuLogic