inflect icon indicating copy to clipboard operation
inflect copied to clipboard

Multiple issues with code on pypi page

Open Protofall opened this issue 5 years ago • 2 comments

I tried running the example code on the pypi page, but there were multiple errors. Aside from undefined variables, I found

  • p.gender('f') raises BadGenderError since 'f' isn't in singular_pronoun_genders
  • Something like print("There" + p.plural_verb("was", errors) + p.no(" error", errors)) prints There[3 SPACES]were[2 SPACES]6[1 SPACE]errors. There's too much whitespace. This happens for many of the functions
  • run/running or run/runner fail all 4 of the compare checks. Not sure if function is broken or that's just a missing case.
  • ~~join() function can't be found at runtime (When installed via pip3) even though I can see it in the downloaded source code from the pypi website.~~

Protofall avatar Oct 09 '20 00:10 Protofall

Thanks for the report, and I'm happy to accept a pull request to repair the issue(s).

Ideally, the docs would be implemented as executable docstrings, such that they're validated as part of the test suite, but it's not obvious to me where those examples should go (as top-level inflect module doc, maybe?). That would be a stretch goal. Just getting the docs to work as advertised is probably sufficient.

Any help you can provide would be appreciated. Thanks!

jaraco avatar Nov 15 '20 00:11 jaraco

  • join() function can't be found at runtime (When installed via pip3) even though I can see it in the downloaded source code from the pypi website.

This issue was addressed in #155.

jaraco avatar Jul 09 '22 15:07 jaraco