StorageDrawers icon indicating copy to clipboard operation
StorageDrawers copied to clipboard

Conversion Upgrade isn't working

Open DanteAyagawe opened this issue 4 years ago • 16 comments

There's an issue I've been having with the Auto-convert item, because as I place a different type of ingot and then another in a compacting drawer with the auto-convert upgrade, it doesn't auto convert the other to the other. I was searching this issue myself and got myself nowhere, I also checked the config file and didn't see anything about manually doing the auto-convert code myself, so yeah I'm really at a lost here.

The version is 1.16.4 and the drawer mod is the most updated ;-; halp

DanteAyagawe avatar Jan 12 '21 22:01 DanteAyagawe

I'm also having this issue and I would love to have it fixed, I have no way I know of to ore-dictionary convert items.

Credit-Score avatar Feb 12 '21 04:02 Credit-Score

Playing the Direwolf20 1.16 pack and ran into this issue myself. Tetra Geodes currently gives different versions of different nuggets. The only way I've found to resolve this is to manually craft them into ingots as I also tried the conversion upgrade and found it didn't work. The ingot recipe works, but the conversion upgrade does not. Compacting drawers were useful for this.

AwesmePersn avatar Mar 13 '21 22:03 AwesmePersn

Same issue. Conversion upgrade is in place but mekanism and tinkers copper are not converting.

ecksfiftyone avatar Jun 05 '21 03:06 ecksfiftyone

Same issue as above with Tinker's, Thermal, and Mekanism installed, which add some of the same metals. Most notably copper, lead, tin, and bronze.

Minecraft 1.16.5 Forge 36.2.2 Storage Drawers 8.3.0 Tinker's Construct 3.1.1.252 Thermal Foundation 1.3.2 Mekanism 10.0.21.448

CodeGordon avatar Aug 08 '21 16:08 CodeGordon

The conversion upgrade is being checked for...

https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/UpgradeData.java#L180-L199 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/UpgradeData.java#L148-L150 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/capabilities/BasicDrawerAttributes.java#L120-L133

...but this isn't actually doing anything in practice.

https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/util/ItemStackOreMatcher.java#L1-L12 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/StandardDrawerGroup.java#L200-L203 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/FractionalDrawerGroup.java#L414-L425 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/FractionalDrawerGroup.java#L471-L478

Functionality for this upgrade is disabled, and apparently has been for a long time.

CodeGordon avatar Aug 11 '21 18:08 CodeGordon

up

ghost avatar Oct 27 '21 15:10 ghost

It's been the better part of a year and nothing has happened on this issue at all.

CodeGordon avatar Oct 29 '21 20:10 CodeGordon

It's been the better part of a year and nothing has happened on this issue at all.

oof... I gave up on the upgrade and just went for alternatives, but damn this would be fucking useful ;-;

DanteAyagawe avatar Oct 29 '21 20:10 DanteAyagawe

@jaquadro you should probably either fix this or disable the conversion upgrade completely. In it's current state it's very misleading.

zoller27osu avatar Nov 29 '21 01:11 zoller27osu

Include the conversion upgrade in the compacting drawers recipe or remove it please, I litteraly googled for 20mins what this upgrade does

ALainxD avatar Dec 11 '21 00:12 ALainxD

bump

EgorIII avatar Feb 13 '22 07:02 EgorIII

also bump

ThatBlockyPenguin avatar Apr 20 '22 13:04 ThatBlockyPenguin

bump

kurobara31694 avatar May 28 '22 20:05 kurobara31694

Bump

Thedeur avatar Jun 11 '22 19:06 Thedeur

A year and a half of nothing from the mod author isn't very encouraging.

CodeGordon avatar Jun 24 '22 00:06 CodeGordon

this is a dumb issue, shouldnt be one and is a really easy fix. just remove it and stop misleading people

DevMunky avatar Mar 09 '23 01:03 DevMunky