Duplication/Conversion Bug: Compacting Drawers

[Danekjovax]

MC 1.16.5 Forge 36.2.31 StorageDrawers-1.16.3-8.5.1 ImmersiveEngineering-1.16.5-5.0.7-143

Seems the previous dupe fix got "some" of the problem I was observing, but not all of it. May be a mod interaction issue at this point. I used the following steps to reproduce:

1. Get a compacting drawer. Place it down.

2. Get a Quantify Key and activate the counter on the compacting drawer.

3. Get 1 bock and 1 ingot of Immersive Engineering Steel in your hotbar. Also grab a diamond and put it in your hotbar.

4. Place the Block of steel into the compacting drawer. (Notice that the ingot slot isn't populating - this is an indication that this block can be duped. Trying to place an ingot in it at this point won't work.)

5. Take the Block out of the drawer then place the ingot in. (Note the correct counts) Pull out the ingot.

6. Place the block back in. (Notice the missing ingot slot again.) Now, pull the block out and then place it back in a second time. (Note the identical counts!)

7. Place the ingot in. Note that the ingot/block numbers are incrementing 1:1.

8. Pull 1 block out, convert it to 9 ingots, then place all ingots into the drawer. Note the same incrementing.

You get the pattern at this point that this can be a duplication exploit. However, there's one other thing I saw while testing:

8. Pull out all Steel ingots/blocks. The drawer should revert to blank state.
9. Place the diamond into the drawer and then pull it back out. (this should show proper behavior).
10. Now, place the blocks of Steel back into the drawer. (Note: things appear like they did in step 3.)
11. Pull all the Steel blocks out and place them back in a second time. Note that the Blocks and diamonds are now showing in the display, with the identical counts.

Placing any diamonds into the drawer at this point will result in a matching increment of Steel blocks.

You see where a player could go with this?

As an extra note, using nuggets can also cause the same conversion/duplication issue between ingots/blocks.

[Elfinlocks]

This is still unresolved and causing issues in my pack. If this could be addressed before 1.16 support is dropped, that would be great. Thanks!

[Quinteger]

Is this issue exclusive to 1.16? Couldn't reproduce on latest 1.18 versions of SD/IE.

[Yappey]

I discovered this issue as well in 1.18 using mod version 10.2.0. You can reproduce it in fewer steps, and it can be used to convert any non-compressible item to any compressible item and vice versa, or any item to any other item if you use two steps.

How to reproduce:

1. Place the compacting drawers
2. Insert a compressible item, then remove it.
3. Insert a non-compressible item, remove it, then replace it.

The non-compressible item will be at the top, and the compressible one will be at the bottom. You can add more of either and then take them out to duplicate.

[Yappey]

I also just realized it works using items that only compress once vs twice.

[Quinteger]

I see, managed to reproduce it in 1.18

[Quinteger]

@Danekjovax @Elfinlocks I fixed the bug in this PR: https://github.com/jaquadro/StorageDrawers/pull/1017. If the issue is urgent and you don't want to wait for the release, you can try building the jar yourself.

[Elfinlocks]

Excellent, thank you! For now we'll wait a little bit for the PR to be approved, as we've kept this one under wraps. ;)

[Danekjovax]

@Danekjovax @Elfinlocks I fixed the bug in this PR: #1017. If the issue is urgent and you don't want to wait for the release, you can try building the jar yourself.

Appreciate your reply. We'll await the release and test again.

[Quinteger]

@Danekjovax @Elfinlocks A new 1.16 release was posted yesterday with the dupe fix and some performance imporvements, give it a try.

[SimonMeskens]

@Quinteger What about 1.18? We've been patiently waiting, but having a dupe glitch on our server is scary.

[Quinteger]

@SimonMeskens The fix was originally done in 1.18, 1.16 was just a backport. The next 1.18 release will have it included.