stm32f103xx-hal icon indicating copy to clipboard operation
stm32f103xx-hal copied to clipboard

Make RCC enr() and rstr() public

Open burrbull opened this issue 7 years ago • 1 comments
trafficstars

Functions for enable, reset peripherals can be used in other crates or in main.

burrbull avatar Jan 29 '18 10:01 burrbull

Thanks for the PR, @burrbull.

I'd rather not make these public as they would let you break all the other abstractions. For example, you create / initialize an instance of Serial but a*b.rstr() lets you reset peripherals and undo the Serial configuration.

Is there a specific use case that you need these changes for? Perhaps there's some other way to achieve it.

japaric avatar Feb 07 '18 20:02 japaric