speedyspeech icon indicating copy to clipboard operation
speedyspeech copied to clipboard

Residual shape in documentation

Open VigneshBaskar opened this issue 2 years ago • 2 comments

Hi Jan, A quick question. In the documentation, the shape of the residual is mentioned as (batch_size, channels, time_dim) here. Can you please confirm if its correct or should it be (batch_size, time_dim, channels). Thank you for your help

VigneshBaskar avatar Jan 16 '22 22:01 VigneshBaskar

Hi Vignesh, it should probably be (batch_size, time_dim, channels), the documentation seems to be wrong.

Regards Jan

ne 16. 1. 2022 v 23:02 odesílatel Vignesh Baskaran @.***> napsal:

Hi Jan, A quick question. In the documentation, the shape of the residual is mentioned as (batch_size, channels, time_dim) here https://github.com/janvainer/speedyspeech/blob/516eb1c6a992dacf5808e416c389e5322d9e80bf/code/layers.py#L189. Can you please confirm if its correct or should it be (batch_size, time_dim, channels). Thank you for your help

— Reply to this email directly, view it on GitHub https://github.com/janvainer/speedyspeech/issues/45, or unsubscribe https://github.com/notifications/unsubscribe-auth/APL4D3LWCA7VXGQ6RGY4QRTUWM6ALANCNFSM5MDIIGKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan Vainer

janvainer2 avatar Jan 17 '22 09:01 janvainer2

Thank you Jan!

VigneshBaskar avatar Jan 17 '22 09:01 VigneshBaskar