backstage-showcase icon indicating copy to clipboard operation
backstage-showcase copied to clipboard

[WIP] Switch AKS tests to `mapt` and spot instances

Open zdrapela opened this issue 1 year ago • 26 comments

Description

This PR is switching the AKS nightly tests from long running cluster (that goes to sleep and wake up) to a spot instance (that is created and then destroyed). This approach allows us to save costs on Azure and gives us a fresh cluster every time, to avoid hiccups that the long running clusters might encounter.

This PR depends on having the https://github.com/janus-idp/backstage-showcase/pull/1643 merged first, to be able to use different auth provider than GitHub for majority of tests. GitHub requires a static callback URL (which is not achievable with mapt, but might be in the future: https://github.com/redhat-developer/mapt/issues/273). GitHub is also not the most stable auth provider and tests sometimes fail because of it.

The same approach as for AKS will be possible for GKE after mapt adds support: https://github.com/redhat-developer/mapt/issues/290

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • [ ] GitHub Actions are completed and successful
  • [ ] Unit Tests are updated and passing
  • [ ] E2E Tests are updated and passing
  • [ ] Documentation is updated if necessary (requirement for new features)
  • [ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

zdrapela avatar Oct 02 '24 05:10 zdrapela

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Oct 02 '24 05:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rm3l for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 02 '24 05:10 openshift-ci[bot]

/ok-to-test

zdrapela avatar Oct 02 '24 05:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 05:10 github-actions[bot]

/test e2e-tests

zdrapela avatar Oct 02 '24 06:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 06:10 github-actions[bot]

/test e2e-tests

zdrapela avatar Oct 02 '24 06:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 07:10 github-actions[bot]

/test e2e-tests

zdrapela avatar Oct 02 '24 07:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 07:10 github-actions[bot]

/test e2e-tests

zdrapela avatar Oct 02 '24 08:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 08:10 github-actions[bot]

/test e2e-tests

zdrapela avatar Oct 02 '24 08:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 09:10 github-actions[bot]

/retest

zdrapela avatar Oct 02 '24 09:10 zdrapela

/test images

zdrapela avatar Oct 02 '24 09:10 zdrapela

/retest-required

zdrapela avatar Oct 02 '24 10:10 zdrapela

/test images

zdrapela avatar Oct 02 '24 11:10 zdrapela

/test e2e

zdrapela avatar Oct 02 '24 11:10 zdrapela

@zdrapela: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-tests
  • /test images

Use /test all to run all jobs.

In response to this:

/test e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 02 '24 11:10 openshift-ci[bot]

/test e2e-tests

zdrapela avatar Oct 02 '24 11:10 zdrapela

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 11:10 github-actions[bot]

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

github-actions[bot] avatar Oct 02 '24 12:10 github-actions[bot]

/test e2e-tests

zdrapela avatar Oct 08 '24 20:10 zdrapela

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Oct 11 '24 06:10 openshift-merge-robot

@zdrapela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 4a12d5fcd35b88bdd3dae028a3a988d99092aee5 link true /test e2e-tests
ci/prow/images 4a12d5fcd35b88bdd3dae028a3a988d99092aee5 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Dec 10 '24 16:12 openshift-ci[bot]

Closing in favor of https://github.com/openshift/release/pull/59507

zdrapela avatar Dec 11 '24 12:12 zdrapela