backstage-plugins icon indicating copy to clipboard operation
backstage-plugins copied to clipboard
verified publisher icon janus-idp

fix(keycloak-backend): delete unused dev dependencies and update test

Open dzemanov opened this issue 1 year ago • 2 comments

General

  • Delete unused dev dependencies
  • Use mockServices rootConfig instead of ConfigReader in tests

Related to

RHIDP-4056

dzemanov avatar Oct 04 '24 23:10 dzemanov

Optional, but I think you can use type for all @keycloak/keycloak-admin-client library imports. And after that you can move this library to the dev dependency.

Thank you for the review. You are totally right, the imports can be changed to type, I will update them. However, @keycloak/keycloak-admin-client can't be moved to dev deps, look at for example this section.

dzemanov avatar Oct 10 '24 09:10 dzemanov

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 10 '24 15:10 sonarqubecloud[bot]