backstage-plugins icon indicating copy to clipboard operation
backstage-plugins copied to clipboard

fix(rbac): refactor PluginPermissionMetadataCollector constructor

Open JessicaJHee opened this issue 1 year ago • 2 comments

Triggered by this disucssion under this PR to migrate RBAC plugin to use the new backend.

This PR changes the constructor to use 2 objects as the arguments instead: deps for mandatory parameters and optional for optional ones.

Fixes RHIDP-4318

JessicaJHee avatar Oct 04 '24 22:10 JessicaJHee

Looks good to me, just need to update due to After 'yarn install', workspace is dirty!

dzemanov avatar Oct 07 '24 10:10 dzemanov

Quality Gate Failed Quality Gate failed

Failed conditions
57.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 09 '24 20:10 sonarqubecloud[bot]