backstage-plugins icon indicating copy to clipboard operation
backstage-plugins copied to clipboard

feat(bulk-import): add audit log to to the backend endpoints [RHIDP-2748]

Open rm3l opened this issue 1 year ago • 3 comments

What does this PR do / why we need it:

This PR adds audit log to the bulk-import backend plugin API endpoints.

Currently draft because it is built on top of https://github.com/janus-idp/backstage-plugins/pull/1890, and will be rebased once this other PR is merged.

Only the last commit in this PR branch is relevant to audit log here.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/RHIDP-2748

PR acceptance criteria:

  • [ ] Unit tests

  • [ ] Integration tests

  • [ ] Documentation

How to test changes / Special notes to the reviewer:

Check the backend logs after sending out a request to any of the Bulk Import Backend API endpoints, e.g.:

TODO(@rm3l): add example


rm3l avatar Jul 26 '24 10:07 rm3l

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from rm3l. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 26 '24 10:07 openshift-ci[bot]

/cc @schultzp2020 @kim-tsao @Zaperex

rm3l avatar Aug 21 '24 12:08 rm3l

Looking at the issues reported by SonarCloud 👀

rm3l avatar Aug 21 '24 13:08 rm3l

looks like this plugin has not been added to the codeowners file so prow will not automerge despite satisfying all the necessary approvals. I will manual merge and update the codeowners file after

kim-tsao avatar Aug 27 '24 16:08 kim-tsao

looks like this plugin has not been added to the codeowners file so prow will not automerge despite satisfying all the necessary approvals. I will manual merge and update the codeowners file after

nvm, we are covered by the codeowners file. Maybe we just had to wait a bit

kim-tsao avatar Aug 27 '24 16:08 kim-tsao

looks like this plugin has not been added to the codeowners file so prow will not automerge despite satisfying all the necessary approvals. I will manual merge and update the codeowners file after

nvm, we are covered by the codeowners file. Maybe we just had to wait a bit

yeah, maybe.. The other PRs that I created in the past related to this plugin were auto-merged by Prow after being approved. Anyway, thanks for merging it manually.

rm3l avatar Aug 27 '24 16:08 rm3l