@janus-idp/backstage-scaffolder-backend-module-servicenow fails the lint sniff test

[nickboldt]

Describe the bug

yarn lint

@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:   ✘  https://google.com/#q=%40typescript-eslint%2Fno-shadow
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      'headers' is already declared in the upper scope on line 126 column 8
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      plugins/servicenow-actions/src/generated/now/table/core/request.ts:132:11
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      130 | 	})
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      131 | 	.filter(([, value]) => value !== undefined && value !== null)
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:    > 132 | 	.reduce((headers, [key, value]) => ({
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:          | 	         ^
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      133 | 		...headers,
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      134 | 		[key]: String(value),
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      135 | 	}), {} as Record<string, string>);
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:   ✘  https://google.com/#q=%40typescript-eslint%2Fno-shadow
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      'resolve' is already declared in the upper scope on line 111 column 14
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      plugins/servicenow-actions/src/generated/now/table/core/request.ts:303:38
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      301 |  */
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      302 | export const request = <T>(config: OpenAPIConfig, options: ApiRequestOptions, axiosClient: AxiosInstance = axios): CancelablePromise<T> => {
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:    > 303 | 	return new CancelablePromise(async (resolve, reject, onCancel) => {
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:          | 	                                    ^
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      304 | 		try {
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      305 | 			const url = getUrl(config, options);
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:      306 | 			const formData = getFormData(options);
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: ✘ 2 problems (2 errors, 0 warnings)
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: 
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: Errors:
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint:   2  https://google.com/#q=%40typescript-eslint%2Fno-shadow
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: error Command failed with exit code 1.
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@janus-idp/backstage-scaffolder-backend-module-servicenow:lint: ERROR: command finished with error: command (/home/nboldt/RHDH/DH/0-janus-idp-plugins-GH/plugins/servicenow-actions) yarn run lint exited (1)

Expected Behavior

linting should pass - see https://typescript-eslint.io/rules/no-shadow/ to avoid shadowed variable resolution

What are the steps to reproduce this bug?

1. check out this repo, switch to main branch
2. yarn install;yarn lint
3. …
4. note failure

Versions of software used and environment

[ciiay]

Hi, I have raised a PR #1668 to fix this issue and it's merged in now. @nickboldt Can you confirm if we could close this issue?